[llvm] r262531 - [MBP] Remove overly verbose debug output

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 16:21:25 PST 2016


Why is it considered over verbose?

David

On Wed, Mar 2, 2016 at 2:40 PM, Philip Reames via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: reames
> Date: Wed Mar  2 16:40:51 2016
> New Revision: 262531
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262531&view=rev
> Log:
> [MBP] Remove overly verbose debug output
>
>
> Modified:
>     llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp
>
> Modified: llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp?rev=262531&r1=262530&r2=262531&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp (original)
> +++ llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp Wed Mar  2 16:40:51
> 2016
> @@ -403,8 +403,6 @@ MachineBlockPlacement::selectBestSuccess
>      } else {
>        BlockChain *SuccChain = BlockToChain[Succ];
>        if (SuccChain == &Chain) {
> -        DEBUG(dbgs() << "    " << getBlockName(Succ)
> -                     << " -> Already merged!\n");
>          SkipSucc = true;
>        } else if (Succ != *SuccChain->begin()) {
>          DEBUG(dbgs() << "    " << getBlockName(Succ) << " -> Mid
> chain!\n");
> @@ -524,10 +522,9 @@ MachineBasicBlock *MachineBlockPlacement
>    BlockFrequency BestFreq;
>    for (MachineBasicBlock *MBB : WorkList) {
>      BlockChain &SuccChain = *BlockToChain[MBB];
> -    if (&SuccChain == &Chain) {
> -      DEBUG(dbgs() << "    " << getBlockName(MBB) << " -> Already
> merged!\n");
> +    if (&SuccChain == &Chain)
>        continue;
> -    }
> +
>      assert(SuccChain.LoopPredecessors == 0 && "Found CFG-violating
> block");
>
>      BlockFrequency CandidateFreq = MBFI->getBlockFreq(MBB);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160302/b3185182/attachment.html>


More information about the llvm-commits mailing list