[PATCH] D17830: [MBP] Avoid placing random blocks between loop preheader and header

David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 16:05:20 PST 2016


davidxl added a comment.

LGTM.


================
Comment at: test/CodeGen/X86/mbp-false-cfg-break.ll:9
@@ +8,3 @@
+; CHECK: # %exit
+; CHECK: # %rare
+; CHECK: # %rare.1
----------------
There does not seem to be a guarantee about the order between rare and rare1. How about using CHECK-NOT to make sure cold blocks are intermixed with hot ones?


http://reviews.llvm.org/D17830





More information about the llvm-commits mailing list