[PATCH] D17832: Retrieve command line arguments and environment correctly on FreeBSD

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 15:45:03 PST 2016


davide added a comment.

LGTM. Probably the Asan owner should sign-off this anyway.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:451
@@ +450,3 @@
+  size_t sz = sizeof(pss);
+  if (sysctlbyname("kern.ps_strings", &pss, &sz, NULL, 0) == -1)
+    pss = (ps_strings*)PS_STRINGS;
----------------
Can you please add a comment explaining what this function is doing for first-readers who don't know sysctl&friends ?


http://reviews.llvm.org/D17832





More information about the llvm-commits mailing list