[PATCH] D17827: Use LineLocation instead of CallsiteLocation to index callsite profile.

[Dehao Chen via llvm-commits]

danielcdh added inline comments.

================
Comment at: include/llvm/ProfileData/SampleProfWriter.h:38
@@ -37,3 +37,3 @@
   /// \returns status code of the file update operation.
-  virtual std::error_code write(StringRef FName, const FunctionSamples &S) = 0;
+  virtual std::error_code write(const FunctionSamples &S) = 0;
 
----------------
dnovillo wrote:
> This will break the AutoFDO tool.
> 
> Idea: keep the old call as a temporary overload.  This gives you time to fix AutoFDO without it breaking on you in the interim.  The version of SampleProfileWriter::write() that takes FName as an argument simply does nothing with it.
Thanks for bring this up.


http://reviews.llvm.org/D17827