[PATCH] D17786: [X86] Enable forwarding bool arguments in tail calls (PR26305)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 08:59:56 PST 2016


rnk added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3666
@@ +3665,3 @@
+
+    break;
+  }
----------------
Maybe a `do { ... } while (false)` loop is appropriate here?

================
Comment at: test/CodeGen/X86/tail-call-bools.ll:1
@@ +1,2 @@
+; RUN: llc -mtriple=i686-unknown-linux-gnu -o - %s | FileCheck %s
+
----------------
Can you also run this in x86_64? The f_i32 guy will have to do `movss %rcx, %xmm0` or something.

Also, maybe `tail-call-casts.ll` is a better name for the test, since it's not all about bools.


http://reviews.llvm.org/D17786





More information about the llvm-commits mailing list