[PATCH] D17782: [X86] Permit reading of the FLAGS register without it being previously defined
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 1 16:21:15 PST 2016
qcolombet added a subscriber: qcolombet.
qcolombet added a comment.
Hi David,
Looks to me like you have two different commits here:
- The modifications of the read flags builtin
- The undef of flags for push/pop instruction
Cheers,
Q.
================
Comment at: lib/Target/X86/X86InstrInfo.td:1130
@@ -1129,3 +1129,3 @@
- let Uses = [RSP, EFLAGS] in
+ let Uses = [RSP] in
def RDFLAGS64 : PseudoI<(outs GR64:$dst), (ins),
----------------
It feels wrong to me that the builtin that reads the flags does *not* use the flags.
http://reviews.llvm.org/D17782
More information about the llvm-commits
mailing list