[PATCH] D17041: [X86] Don't assume that a shuffle operand is #0: it isn't for VPERMV.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 15:46:17 PST 2016


ab marked 6 inline comments as done.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:5038
@@ -5031,1 +5037,3 @@
     IsUnary = true;
+    // Unlike most shuffle nodes, VPERMV's mask operand is operand 0.
+    Ops.push_back(N->getOperand(1));
----------------
Yeah, Elena also mentioned VPERMT2 and (the worst of all) VPERMI2. I have lost all hope!


http://reviews.llvm.org/D17041





More information about the llvm-commits mailing list