[PATCH] D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:237
@@ -222,2 +236,3 @@
 public:
-  virtual void printFileHeaders(const ELFFile<ELFT> *Obj) = 0;
+  TYPEDEF_ELF_TYPES(ELFT)
+  virtual void printFileHeaders(const ELFO *Obj) = 0;
----------------
Do you need the typedef here?

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2239
@@ +2238,3 @@
+    Bias = 0;
+    FmtCharHex = "%08" PRIx32;
+  }
----------------
Is there a type safe api you could use?
 format_decimal maybe?

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2297
@@ +2296,3 @@
+    OS << "\nRelocation section '" << Name << "' at offset 0x"
+       << to_hexString(Offset, false) << " contains " << to_string(Entries)
+       << " entries:\n";
----------------
why do you need the to_string here?


Repository:
  rL LLVM

http://reviews.llvm.org/D17523