[llvm] r262384 - TableGen: Check scheduling models for completeness

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 13:41:15 PST 2016


I added a helpfull message on how to deal with incomplete models in r262399.

> On Mar 1, 2016, at 1:21 PM, Matthias Braun via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Ok I can add that.
> 
> Though in many cases you can easily piece some scheduling information together with existing SchedWrite/SchedRead classes and do not have to modify all the scheduling models.
> 
> - Matthias
> 
>> On Mar 1, 2016, at 1:19 PM, Tim Northover via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> Hi Matthias,
>> 
>>> +          PrintError("No schedule information for instruction '"
>>> +                     + Inst->TheDef->getName() + "'");
>> 
>> I think this needs a better diagnostic. The most common way this will
>> be hit is when some poor sucker is trying to test out a new
>> instruction and suddenly discovers he needs to mark it unsupported on
>> umpteen schedulers before LLVM will even compile his code.
>> 
>> I'd suggest explicitly calling out hasNoSchedulingInfo as a temporary
>> development fix.
>> 
>> Cheers.
>> 
>> Tim.
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list