[PATCH] D17758: [ELF] - handle of command line options incompatible with -r

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Driver.cpp:144
@@ -143,3 +143,3 @@
 
-  if (Config->Relocatable && Config->Shared)
-    error("-r and -shared may not be used together");
+  if (Config->Relocatable) {
+    if (Config->Shared)
----------------
I'd use early return here.

  if (Config->Relocatable)
    return;
  if (Config->Shared)
    ....

================
Comment at: test/ELF/relocatable-errors.s:1-2
@@ +1,3 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1.o
+
----------------
Please add this to driver.test instead of to a new file.


http://reviews.llvm.org/D17758