[PATCH] D17774: [ELF] - do not create special symbols when creating relocatable output

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 09:58:36 PST 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Writer.cpp:1004
@@ -1003,4 +1003,3 @@
   // addresses of each section by section name. Add such symbols.
-  addStartEndSymbols();
-  for (OutputSectionBase<ELFT> *Sec : RegularSections)
-    addStartStopSymbols(Sec);
+  if (!Config->Relocatable) {
+    addStartEndSymbols();
----------------
Instead of here, please add "if (Config->Relocatable) return;" at beginning of addStartEndSymbols.


http://reviews.llvm.org/D17774





More information about the llvm-commits mailing list