[PATCH] D17742: Perform InstructioinCombiningPass before SampleProfile pass.

[Diego Novillo via llvm-commits]

dnovillo added a comment.

Could you give me a bit more context?  A C/C++ motivating example would be great.  I think I follow what the intent is, but I'd like to make sure and leave it documented in the commit log.

Thanks.


================
Comment at: test/Transforms/SampleProfile/cov-zero-samples.ll:3
@@ -2,3 +2,3 @@
 ;
-; CHECK: remark: cov-zero-samples.cc:9:25: Applied 404065 samples from profile (offset: 2.1)
+; CHECK: remark: cov-zero-samples.cc:9:29: Applied 404065 samples from profile (offset: 2.1)
 ; CHECK: remark: cov-zero-samples.cc:10:9: Applied 443089 samples from profile (offset: 3)
----------------
Why did the discriminators change here?  Was this because of instcombine?  What did it do?

================
Comment at: test/Transforms/SampleProfile/inline-coverage.ll:19
@@ -18,3 +18,3 @@
 ; CHECK: remark: coverage.cc:10:12: inlined hot callee '_Z3fool' with 172746 samples into 'main'
-; CHECK: remark: coverage.cc:9:19: Applied 23478 samples from profile (offset: 2.1)
+; CHECK: remark: coverage.cc:9:21: Applied 23478 samples from profile (offset: 2.1)
 ; CHECK: remark: coverage.cc:10:16: Applied 23478 samples from profile (offset: 3)
----------------
Likewise here.  Why did the discriminators change?


http://reviews.llvm.org/D17742