[PATCH] D17542: Disallow generating vzeroupper before return instruction (iret) in interrupt handler function
Amjad Aboud via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 1 03:37:22 PST 2016
aaboud added a comment.
In http://reviews.llvm.org/D17542#364850, @ab wrote:
> Sorry to be a nag, but the testcase can be simplified even further:
>
> ; RUN: llc -mtriple=x86_64-unknown-unknown -mattr=+avx < %s | FileCheck %s
>
> ; CHECK: vzeroupper
> ; CHECK-NEXT: call
> ; CHECK-NOT: vzeroupper
> ; CHECK: iret
>
> define x86_intrcc void @foo(i8* %frame) {
> call void @bar()
> ret void
> }
>
> declare void @bar()
>
>
>
> FWIW, I also don't think the C reproducer adds any value, but if you think otherwise feel free to keep it!
OK, I modified the testcase and committed the patch.
Thanks for the review.
Repository:
rL LLVM
http://reviews.llvm.org/D17542
More information about the llvm-commits
mailing list