[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D16201#364697, @zatrazz wrote:

> However I still think it is something missing, I am still seeing some issues with bootstrap with an random testcase:


That might be not something directly relative with this patch. At least all sample apps that uses TLSDESC relocations are working now. And we probably can land this and continue investigating issues and fix them separatelly. What do you think ?


================
Comment at: ELF/InputSection.cpp:282
@@ +281,3 @@
+      Target->relocateOne(BufLoc, BufEnd, Type, AddrLoc,
+                          Body->getGotPltRevVA<ELFT>() + getAddend<ELFT>(RI));
+      continue;
----------------
zatrazz wrote:
> I think you could just use the already got addend 'A' at line 235.
Done.

================
Comment at: ELF/OutputSections.cpp:239
@@ -209,1 +238,3 @@
+                                 Out<ELFT>::Got->getTlsDescEntryVA(),
+                                 Out<ELF64LE>::GotPlt->getVA());
 }
----------------
zatrazz wrote:
> I think this should use the non-specialized 'GotPlt' access (Out<ELT>::GotPlt).
Fixed.


http://reviews.llvm.org/D16201