[PATCH] D17095: [X86] Add X86FixupSeparateStack pass

[Craig Topper via llvm-commits]

craig.topper added a subscriber: craig.topper.

================
Comment at: lib/Target/X86/X86.td:246
@@ -242,2 +245,3 @@
+                       " by adding segment override prefixes (X86-32 only).">;
 
 //===----------------------------------------------------------------------===//
----------------
Can this be done with a command line switch in X86TargetMachine.cpp like VZeroUpper? I don't see that this needs to be a feature bit.

================
Comment at: lib/Target/X86/X86FixupSeparateStack.cpp:599
@@ +598,3 @@
+
+    bool HasEVEX_K = TSFlags & X86II::EVEX_K;
+    bool HasVEX_4V = TSFlags & X86II::VEX_4V;
----------------
delena wrote:
> Why masked instructions are out of scope?
> DestMem can't be VEX_4V.
DestMem can be VEX_4V. We check for it in both MCCodeEmitter and the Disassembler. I believe at least vmaskmovpd uses it.


http://reviews.llvm.org/D17095