[PATCH] D17744: AMDGPU: Insert moves of frame index to value operands

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 16:51:12 PST 2016


arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
Herald added a subscriber: arsenm.

Strengthen tests of storing frame indices.
    
Right now this just creates irrelevant scheduling changes.
    
We don't want to have multiple frame index operands
on an instruction. There seem to be various assumptions
that at least the same frame index will not appear twice
in the LocalStackSlotAllocation pass.
    
There's no reason to have this happen, and it just
makes it easy to introduce bugs where the immediate
offset is appplied to the storing instruction when it should
really be applied to the value being stored as a separate
add.

http://reviews.llvm.org/D17744

Files:
  lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  test/CodeGen/AMDGPU/captured-frame-index.ll
  test/CodeGen/AMDGPU/promote-alloca-stored-pointer-value.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17744.49434.patch
Type: text/x-patch
Size: 9605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160301/bc99ac92/attachment.bin>


More information about the llvm-commits mailing list