[PATCH] D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.

[Arpith Jacob via llvm-commits]

arpith-jacob marked 2 inline comments as done.
arpith-jacob added a comment.

In http://reviews.llvm.org/D17738#364717, @rafael wrote:

> Wouldn't it be better to error and ask the llvm producer to not create
>  global values with '@' and '.' when targeting nvptx?


Unfortunately the llvm producer changed, which broke code for this target without anyone noticing :(


================
Comment at: lib/Target/NVPTX/NVPTXAssignValidGlobalNames.cpp:74
@@ +73,3 @@
+  while (1) {
+    std::string ValidName = cleanUpName(V.getName());
+    // setName doesn't do extra work if the name does not change.
----------------
Ouch!


http://reviews.llvm.org/D17738