[PATCH] D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 29 14:38:07 PST 2016
jlebar added a comment.
In http://reviews.llvm.org/D17738#364717, @rafael wrote:
> Wouldn't it be better to error and ask the llvm producer to not create
> global values with '@' and '.' when targeting nvptx?
http://reviews.llvm.org/rL205212 suggests we already do generic sanitizing for all backends. If that's true, why is it inappropriate to do target-specific sanitization in addition? That seems cleaner than playing whack-a-mole in the frontend so it doesn't emit names that aren't valid, when compiling for this target.
http://reviews.llvm.org/D17738
More information about the llvm-commits
mailing list