[PATCH] D17733: [ELF] Fix reading of PC values of FDEs

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 14:32:58 PST 2016


rafael added inline comments.

================
Comment at: ELF/OutputSections.cpp:675
@@ -676,2 +674,3 @@
   case DW_EH_PE_sdata2:
-    return FdeOff + read16<E>(F.PCRel);
+    PC = read16<E>(F.PCRel);
+    break;
----------------
This might be shorter as a lambda so that you can just return PC.

================
Comment at: test/ELF/eh-frame-hdr-abs-fde.s:21
@@ +20,3 @@
+# CHECK-NEXT:  10138 02000b0c 1d000000 00000014 0000001c
+#                    ^-- 'z'
+#                      ^-- 'L' - LSDA encoding
----------------
Can you use objdump to get a parsed content?


Repository:
  rL LLVM

http://reviews.llvm.org/D17733





More information about the llvm-commits mailing list