[PATCH] D17663: [JumpThreading] See through Cast Instructions

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 12:11:40 PST 2016


gberry added a comment.

I see what you're saying, but perhaps a better motivating example would be a case where the zext was of a phi value that was only constant on some paths?
The example (and test) you give above seems more like a phase-ordering issue, since simplifying away the zext completely seems like something that should already be happening outside of JumpThreading.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:485
@@ +484,3 @@
+
+    // Invert the known values.
+    for (auto &R : Result)
----------------
This comment is incorrect, right?


Repository:
  rL LLVM

http://reviews.llvm.org/D17663





More information about the llvm-commits mailing list