[PATCH] D17659: [X86] Move the ATOMIC_LOAD_OP ISel from DAGToDAG to ISelLowering. NFCI.
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 29 07:46:13 PST 2016
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Just one comment, otherwise it looks reaonable.
Tim.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:20380-20381
@@ +20379,4 @@
+ // We can lower atomic_load_add into LXADD. However, any other atomicrmw op
+ // can only be lowered when the result is unused. They should have already
+ // been transformed into a cmpxchg loop in AtomicExpand.
+ if (N->hasAnyUseOfValue(0)) {
----------------
Can we assert on that?
http://reviews.llvm.org/D17659
More information about the llvm-commits
mailing list