[PATCH] D17011: [lanai] Add Lanai backend.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 07:44:30 PST 2016


chandlerc added a comment.

In http://reviews.llvm.org/D17011#364281, @chandlerc wrote:

> In http://reviews.llvm.org/D17011#364260, @t.p.northover wrote:
>
> > Hi,
> >
> > Sorry it took so long to take a look here.
> >
> > This seems like a fairly straightforward backend commit, and most of the code looks fine. My comments are generally trivia.
> >
> > I think the biggest issue is that the CodeGen test coverage is fairly weak.
>
>
> I had thought that Jacques had indicated that most of the tests were in a separate patch just for size reasons, but I can't now find that patch....


NM, the tests got merged in, and we just need more of them.


http://reviews.llvm.org/D17011





More information about the llvm-commits mailing list