[PATCH] D17212: [ThinLTO] Support for call graph in per-module and combined summary.

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5528
@@ -5481,2 +5527,3 @@
         TheIndex->addFunctionInfo(FunctionGlobalId, std::move(FuncInfo));
+        ValueIdToCallGraphGUIDMap[ValueID] = Function::getGUID(ValueName);
       }
----------------
Good catch! Yes, it should be. The VST_CODE_ENTRY case does not need to invoke getGlobalIdentifier since those are externally-defined functions (and so not possibly local).

But looking at the other places here where we set up this map I realized that the VST_CODE_COMBINED_FNENTRY case was wrong - we already have the GUID and there is no ValueName in that record. I have a fix for both coming up shortly.


http://reviews.llvm.org/D17212