[PATCH] D16810: [mips] Make isel select the correct DEXT variant up front.

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 03:28:44 PST 2016


vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.

LGTM, with a small change as described in the in-line comment.


================
Comment at: lib/Target/Mips/MipsInstrInfo.td:808-816
@@ -800,1 +807,11 @@
 
+def immZExt5Plus1 : PatLeaf<(imm), [{
+  return isUInt<5>(N->getZExtValue() - 1);
+}]>;
+def immZExt5Plus32 : PatLeaf<(imm), [{
+  return isUInt<5>(N->getZExtValue() - 32);
+}]>;
+def immZExt5Plus33 : PatLeaf<(imm), [{
+  return isUInt<5>(N->getZExtValue() - 33);
+}]>;
+
----------------
The names imply that we add a constant to the zext'd value, but we perform a subtraction instead.


http://reviews.llvm.org/D16810





More information about the llvm-commits mailing list