[PATCH] D17477: [Polly] [RFC] Allow the client of DependenceInfo to obtain dependences at different granularities.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 28 08:37:14 PST 2016


Meinersbur added inline comments.

================
Comment at: lib/Analysis/DependenceInfo.cpp:793-794
@@ -772,3 +792,4 @@
 void DependenceInfo::getAnalysisUsage(AnalysisUsage &AU) const {
-  ScopPass::getAnalysisUsage(AU);
+  AU.addRequiredTransitive<ScopInfo>();
+  AU.setPreservesAll();
 }
----------------
Apart from `recomputeDependences()` the DependenceInfo did not need the Scop anymore. All results were stored in isl_* structures.

However, the analysis results without having the ScopStmt, MemoryAccess they were computed from available might be not that useful, but it is not strictly necessary. So I guess, no problem with always using `addRequiredTransitive<ScopInfo>()`. Users of DependenceInfo will have a `addRequired[Transitive]<ScopInfo>()` anyway.


http://reviews.llvm.org/D17477





More information about the llvm-commits mailing list