[PATCH] D17687: Remove range.h.

Pete Cooper via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 27 19:59:43 PST 2016


Hi Ruiu

LGTM. 

Seems like you replaced the uses with ArrayRef which is better anyway.

Thanks
Pete

Sent from my iPhone

> On Feb 27, 2016, at 6:46 PM, Rui Ueyama <ruiu at google.com> wrote:
> 
> ruiu created this revision.
> ruiu added a reviewer: pete.
> ruiu added a subscriber: llvm-commits.
> 
> IIUC, range was an experiment to see how N3350 would work in LLD.
> It turned out it didn't get traction, and it is basically duplicate
> of iterator_range in ADT. We have only two occurrences of range,
> and all of them are easily rewritten without it.
> 
> http://reviews.llvm.org/D17687
> 
> Files:
>  include/lld/Core/File.h
>  include/lld/Core/LinkingContext.h
>  include/lld/Core/Parallel.h
>  include/lld/Core/Pass.h
>  include/lld/Core/Simple.h
>  include/lld/Core/range.h
>  include/lld/ReaderWriter/LinkerScript.h
>  unittests/CoreTests/CMakeLists.txt
>  unittests/CoreTests/RangeTest.cpp
> 
> <D17687.49305.patch>


More information about the llvm-commits mailing list