[PATCH] D17477: [Polly] [RFC] Allow the client of DependenceInfo to obtain dependences at different granularities.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 23:22:47 PST 2016


grosser added a comment.

> I think I know why.

> 

> Because originally we compute Dependences in runOnScop, when we call printScop/getDependences, we simply return the calculated Dependences, the Scop do not need to present.

> 

> However, practically, all Scop analyses should  "addRequiredTransitive<ScopInfo>();", since they are all calculated based on the Scop. If the Scop is invalided, the corresponding analysis results should also be invalided. Especially when the Scop is invalided by the transformations that change CFG and/or memory access behaviors.


Right. We should add RequiredTransitive. Feel free to change this.

Best,
Tobias


Repository:
  rL LLVM

http://reviews.llvm.org/D17477





More information about the llvm-commits mailing list