[PATCH] D17672: [instrprof] Use __{start, stop}_SECNAME on PS4 too.

[Sean Silva via llvm-commits]

On Fri, Feb 26, 2016 at 10:16 PM, Xinliang David Li <davidxl at google.com>
wrote:

>
>
> On Fri, Feb 26, 2016 at 10:12 PM, Sean Silva <chisophugis at gmail.com>
> wrote:
>
>> silvas added a comment.
>>
>> Thanks David. r262112.
>>
>> In http://reviews.llvm.org/D17672#363502, @davidxl wrote:
>>
>> > This one looks fine. There is a compiler-rt part too.
>>
>>
>> Curiously PS4 defines __FreeBSD__ and we we were actually already taking
>> the linker magic `#ifdef`. I actually ran into this somewhat accidentally
>> when using an upstream compiler-rt for PS4. I actually encountered link
>> errors for missing `__llvm_profile_register_function` et al. which gave me
>> the motivation to look closer. In the end this change seemed like the
>> natural thing to do since it was a win-win for reducing our private patches
>> and also getting the improved startup time.
>>
>
> ok. Does PS4 define its own platform macro? It might be better to make it
> more explicit.
>

Yes, it has __PS4__ in the upstream compiler which will be used for gating
differences between PS4 and FreeBSD.

-- Sean Silva


>
> David
>
>
>>
>>
>> Repository:
>>   rL LLVM
>>
>> http://reviews.llvm.org/D17672
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160226/566cae7c/attachment.html>