[PATCH] D17672: [instrprof] Use __{start, stop}_SECNAME on PS4 too.
Sean Silva via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 26 22:12:57 PST 2016
silvas added a comment.
Thanks David. r262112.
In http://reviews.llvm.org/D17672#363502, @davidxl wrote:
> This one looks fine. There is a compiler-rt part too.
Curiously PS4 defines __FreeBSD__ and we we were actually already taking the linker magic `#ifdef`. I actually ran into this somewhat accidentally when using an upstream compiler-rt for PS4. I actually encountered link errors for missing `__llvm_profile_register_function` et al. which gave me the motivation to look closer. In the end this change seemed like the natural thing to do since it was a win-win for reducing our private patches and also getting the improved startup time.
Repository:
rL LLVM
http://reviews.llvm.org/D17672
More information about the llvm-commits
mailing list