[PATCH] D17568: [TableGen] AsmMatcher: Skip optional operands in the midle of instruction if it is not present

[Ahmed Bougacha via llvm-commits]

ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

LGTM, but please wait for http://reviews.llvm.org/D17644.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:3137-3139
@@ -3133,2 +3136,5 @@
   OS << "      }\n";
+  OS << "      if (Diag == Match_InvalidOperand "
+     << "&& isSubclass(Formal, OptionalMatchClass))\n";
+  OS << "        continue;\n";
   OS << "      // If this operand is broken for all of the instances of this\n";
----------------
An extra comment here would help, I think.


http://reviews.llvm.org/D17568