[PATCH] D17269: [ELF] - Implemented linkerscript sections padding.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 26 05:07:02 PST 2016
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/LinkerScript.cpp:61
@@ +60,3 @@
+ return C.Filler;
+ return{};
+}
----------------
return{} -> return {}
================
Comment at: ELF/LinkerScript.cpp:451
@@ +450,3 @@
+ StringRef Tok = peek();
+ if (Tok[0] == '=') {
+ if (!Tok.startswith("=0x")) {
----------------
This is not safe because Tok may be empty.
if (Tok.startswith("="))
http://reviews.llvm.org/D17269
More information about the llvm-commits
mailing list