[PATCH] D17639: [asan] Fix recvfrom.cc testcase failure in large parallel tests run.

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 03:06:31 PST 2016


m.ostapenko added inline comments.

================
Comment at: test/asan/TestCases/Linux/recvfrom.cc:37
@@ +36,3 @@
+    serveraddr.sin_port = htons(kPortNum);
+  }
+  // Release the mutex since the server is ready now and kPortNum has proper
----------------
ygribov wrote:
> SO says (http://stackoverflow.com/questions/1075399/how-to-bind-to-any-available-port) that you can specify port 0 so that kernel selects it automatically for you.
Nice, thanks!

================
Comment at: test/asan/TestCases/Linux/recvfrom.cc:40
@@ -35,1 +39,3 @@
+  // value.
+  pthread_mutex_unlock(&server_ready_mu);
   recvfrom(sockfd, buf, kBufSize, 0, NULL, NULL); // BOOM
----------------
dvyukov wrote:
> I don't see where the mutex is locked... where is it?
Eh, It seems I attached truncated patch. Sorry about that.


Repository:
  rL LLVM

http://reviews.llvm.org/D17639





More information about the llvm-commits mailing list