[PATCH] D17607: [ELF] - Create _DYNAMIC symbol for dynamic output

[Ed Maste via llvm-commits]

emaste added a comment.

I'm seeing strange test failures in my self-hosted lld testrun with this patch applied.

Test process is:

1. cd 1st stage build dir, configured with FreeBSD host compiler (Clang 3.4.1) and ld.bfd (2.17.50)
2. `ninja lld`
3. `ninja check-lld`
4. cd 2nd stage build dir, configured with FreeBSD host compiler (Clang 3.4.1) and ld.lld from (2)
5. `ninja lld`
6. `ninja check-lld`

(3) passes, (6) fails in strange ways, for example:

  ********************
  FAIL: lld :: COFF/entrylib.ll (33 of 1003)
  ******************** TEST 'lld :: COFF/entrylib.ll' FAILED ********************
  Script:
  --
  llvm-as -o /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.obj /tank/emaste/src/llvm/tools/lld/test/COFF/entrylib.ll
  rm -f /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.lib
  llvm-ar cru /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.lib /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.obj
  /tank/emaste/src/llvm/build-lld-selfhost2/./bin/lld-link /out:/tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.exe /entry:main /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.lib
  --
  Exit Code: 134
  
  Command Output (stderr):
  --
  warning: /machine is not specified. x64 is assumed.
  Assertion failed: (Str && "StringRef cannot be built from a NULL argument"), function StringRef, file ../include/llvm/ADT/StringRef.h, line 73.
  #0 0x0000000000f3fd8e llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/tank/emaste/src/llvm/build-lld-selfhost2/bin/lld+0xf3fd8e)
  #1 0x0000000000f40199 PrintStackTraceSignalHandler(void*) (/tank/emaste/src/llvm/build-lld-selfhost2/bin/lld+0xf40199)
  #2 0x0000000000f3ca97 llvm::sys::RunSignalHandlers(void) (/tank/emaste/src/llvm/build-lld-selfhost2/bin/lld+0xf3ca97)
  #3 0x0000000000f405cc SignalHandler(int) (/tank/emaste/src/llvm/build-lld-selfhost2/bin/lld+0xf405cc)
  #4 0x00000008046f695a handle_signal /tank/emaste/src/git-stable-10/lib/libthr/thread/thr_sig.c:249:0
  #5 0x00000008046f6158 thr_sighandler /tank/emaste/src/git-stable-10/lib/libthr/thread/thr_sig.c:189:0
  /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.script: line 4: 85785 Abort trap              (core dumped) /tank/emaste/src/llvm/build-lld-selfhost2/./bin/lld-link /out:/tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.exe /entry:main /tank/emaste/src/llvm/build-lld-selfhost2/tools/lld/test/COFF/Output/entrylib.ll.tmp.lib
  
  --


http://reviews.llvm.org/D17607