[PATCH] D17502: [ELF] - Fix of 22906, referencing __start or __stop should keep the section from GC.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 23:13:27 PST 2016


grimar added inline comments.

================
Comment at: test/ELF/startstop-gccollect.s:1
@@ +1,2 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
----------------
ruiu wrote:
> You want to remove __start and __stop symbols from the test and just verify that we do not reclaim sections if their section names are valid C identifiers.
That was already done in latest diff, no ? :)
__start_/__stop_ are just mentioned in comments to explain the behavior logic.


http://reviews.llvm.org/D17502





More information about the llvm-commits mailing list