[PATCH] D11972: AMDGPU: Set MCAsmInfo::PointerSize

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 21:02:53 PST 2016


arsenm added a comment.

In http://reviews.llvm.org/D11972#299510, @tstellarAMD wrote:

> Do we still need this patch?


I think so


================
Comment at: test/CodeGen/AMDGPU/basic-debug-info.ll:35
@@ +34,3 @@
+!14 = !{i32 2, !"Debug Info Version", i32 3}
+!15 = !{!"clang version 3.8.0 (trunk 244715) (llvm/trunk 244718)"}
+!16 = !DILocation(line: 4, column: 1, scope: !4)
----------------
tstellarAMD wrote:
> Do we need this clang version in the test?  Can any of this other metadata be safely dropped?
> 
The clang version should be droppable. Most of it probably can be, I'm not exactly sure what the minimum required is


http://reviews.llvm.org/D11972





More information about the llvm-commits mailing list