[PATCH] D16381: Infrastructure to allow use of PGO in inliner

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 16:33:16 PST 2016


eraman added a comment.

Ping. I would like to move forward on this to enable PGO improvements in
inliner and function layout (separating cold functions becomes effective if
we have their entry counts after inlining). Specifically, I think the code
that computes BFA is isolated enough that ripping it out when inliner is
ported to the new pass manager is not very intrusive.

I did more testing as asked by David. Specifically,

1. Turn on the updates by default (instead of inly in PGO) and ran llvm

testsuite

2. Turn on the updates by default and build clang.
3. Build Google internal compiler benchmark suite in PGO mode with this

patch enabled.

These tests above didn't reveal any issues.

Thanks,
Easwaran


http://reviews.llvm.org/D16381





More information about the llvm-commits mailing list