[PATCH] D16440: [ThinLTO] Link in only necessary DICompileUnit operands

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 10:09:46 PST 2016


> On Feb 24, 2016, at 10:06 AM, Teresa Johnson <tejohnson at google.com> wrote:
> 
> tejohnson added a comment.
> 
> In http://reviews.llvm.org/D16440#360836, @tejohnson wrote:
> 
>> Add a new option to control full importing of types. By default import
>> only type decls instead of full defs.
> 
> 
> Let me know if this is too big of a hammer. For now it will essentially turn off this entire patch, meaning not only will we get the full type defs, but we also import the full dbg.cu (including enums, etc).

"Big hammer" is enough for me to get this patch in.
Put the burden of improving this on the people who need it while not breaking what works now is always a good strategy :)

-- 
Mehdi


More information about the llvm-commits mailing list