[PATCH] D17333: [lld] [AArch64] Initial TLSDESC relocations support

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Target.cpp:1485
@@ -1470,2 +1484,3 @@
+    break;
   default:
     fatal("unrecognized reloc " + Twine(Type));
----------------
I would add some comment here.

================
Comment at: ELF/Target.h:92
@@ -90,2 +91,3 @@
+  unsigned TlsDescRel = 0;
   unsigned PltEntrySize = 8;
   unsigned PltZeroSize = 0;
----------------
I dont think you want '= 0' here, we dont initialize other relocation fields.

================
Comment at: ELF/Writer.cpp:276
@@ -266,2 +275,3 @@
   }
+
   return !Target->isTlsDynRel(Type, *Body);
----------------
No need in this empty line.


Repository:
  rL LLVM

http://reviews.llvm.org/D17333