[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 02:41:05 PST 2016


grimar added a comment.

In http://reviews.llvm.org/D16201#359660, @zatrazz wrote:

> Although my TLSDESC patch have missing bits (as you pointed out and I am inclided to abandon it), there is something missing on this patch. Although I can bootstrap the compiler itself, the make check-ldd is stuck in:
>
> tools/lld/unittests/DriverTests/DriverTests --gtest_list_tests
>
> (gdb) bt
>  #0  0x0000007f8842ca04 in __lll_lock_wait (futex=0x34c59980, private=0) at lowlevellock.c:46
>  #1  0x0000007f88428964 in __GI___pthread_rwlock_rdlock (rwlock=0x34c59980) at pthread_rwlock_rdlock.c:113
>  #2  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #3  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #4  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #5  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #6  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #7  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #8  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  #9  0x0000000001971c54 in llvm::sys::RWMutexImpl::RWMutexImpl() ()
>  [...]
>  (gdb) info threads
>
>   Id   Target Id         Frame 
>
> - 1    Thread 0x7f880c8000 (LWP 14280) "DriverTests" 0x0000007f8842ca04 in __lll_lock_wait (futex=0x34c59980, private=0) at lowlevellock.c:46
>
>   Where with my patch I can bootstrap and run all the make-ldd tests without issue. I am debugging this with your patch.


Thanks for info ! I`ll review the output produced by this patch once again.


http://reviews.llvm.org/D16201





More information about the llvm-commits mailing list