[PATCH] D17529: ELF: Implement ICF.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 17:17:58 PST 2016


ruiu added inline comments.

================
Comment at: ELF/ICF.cpp:170
@@ +169,3 @@
+    InputSection<ELFT> *Head = *I;
+    auto Bound = std::partition(
+        I + 1, End, [&](InputSection<ELFT> *S) { return Eq(Head, S); });
----------------
Done.

================
Comment at: ELF/ICF.cpp:174
@@ +173,3 @@
+      return Ret;
+    uint64_t Id = NextId++;
+    for (; I != Bound; ++I)
----------------
Done.

================
Comment at: ELF/ICF.cpp:206
@@ +205,3 @@
+  const RelTy *EB = RelsB.end();
+  if (EA - IA != EB - IB)
+    return false;
----------------
Done.


http://reviews.llvm.org/D17529





More information about the llvm-commits mailing list