[PATCH] D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files

[Eric Christopher via llvm-commits]

echristo added a comment.

Still LGTM. Thanks!


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:523
@@ -459,3 +522,3 @@
                                             const Elf_Sym *symb,
-                                            bool &IsDefault) {
+                                            bool &IsDefault) const {
   // This is a dynamic symbol. Look in the GNU symbol version table.
----------------
khemant wrote:
> This is the patch that introduced the pointer. I would like to have it const from beginning instead of retrofitting in future as it will cause larger unneeded churn.
Oh sure. Never that. First maybe, but not after.




Repository:
  rL LLVM

http://reviews.llvm.org/D17523