[PATCH] D5227: [Polly] Support ModRef function behaviour

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 12:19:53 PST 2016


jdoerfert added inline comments.

================
Comment at: lib/Analysis/ScopInfo.cpp:3979
@@ +3978,3 @@
+      addArrayAccess(Inst, AccType, ArgBasePtr->getValue(),
+                     ArgBasePtr->getType(), false, {AF}, {}, &CI);
+    }
----------------
jdoerfert wrote:
> Meinersbur wrote:
> > What happens if there are other multi-dimensional accesses to the same array exist?
> This is also a really good point! Thanks! I will add a test case and add code to the ScopDetection that will prevent us to delinearize a base pointer that is used in such a call (The same problem is actually present for MemIntrinsics, thus I will push the check and another test prior to this one). Later we can lift that restriction and make the access we create here multidimensional. Again I would like to do that in a follow-up patch if you agree.
Forget the part in the parenthesis, that was not true.


http://reviews.llvm.org/D5227





More information about the llvm-commits mailing list