[PATCH] D17474: MachineCopyPropagation: Keep scanning through instructions with regmasks

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Matthias,

Nice clean up.

Looks good to me, modulo my inlined comments for the test cases.
Please also look into Jun's comment.

Thanks,
-Quentin


================
Comment at: test/CodeGen/X86/machine-copy-prop.mir:8
@@ +7,3 @@
+---
+# CHECK-LABEL: name: copyprop1
+# CHECK: bb.0:
----------------
Could you add a comment on what this function is testing?
Something pretty obvious like check that copy propagation manages to propagate across calls when the registers are preserved.

================
Comment at: test/CodeGen/X86/machine-copy-prop.mir:21
@@ +20,2 @@
+    NOOP implicit %rax, implicit %rdi
+...
----------------
Add another test where the copy cannot be propagated because of clobbered registers.


Repository:
  rL LLVM

http://reviews.llvm.org/D17474