[PATCH] D17527: Handle bitcode files in archive files with --whole-archive.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 10:15:53 PST 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: ELF/InputFiles.cpp:460
@@ -459,4 +459,3 @@
 static std::unique_ptr<InputFile> createELFFileAux(MemoryBufferRef MB) {
-  std::unique_ptr<T> Ret = llvm::make_unique<T>(MB);
-
+  std::unique_ptr<T> Ret(new T(MB));
   if (!Config->FirstElf)
----------------
Why remove the llvm::make_unique?

================
Comment at: ELF/InputFiles.cpp:464
@@ -463,3 +462,2 @@
     Config->FirstElf = Ret.get();
-
   if (Config->EKind == ELFNoneKind) {
----------------
unrelated white space change.


http://reviews.llvm.org/D17527





More information about the llvm-commits mailing list