[llvm] r261652 - [InstCombine] less indenting; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 08:59:24 PST 2016


Author: spatel
Date: Tue Feb 23 10:59:21 2016
New Revision: 261652

URL: http://llvm.org/viewvc/llvm-project?rev=261652&view=rev
Log:
[InstCombine] less indenting; NFC

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp?rev=261652&r1=261651&r2=261652&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp Tue Feb 23 10:59:21 2016
@@ -1245,38 +1245,39 @@ static Instruction *matchDeMorgansLaws(B
 
 Instruction *InstCombiner::foldCastedBitwiseLogic(BinaryOperator &I) {
   Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
-  if (CastInst *Op0C = dyn_cast<CastInst>(Op0)) {
-    Value *Op0COp = Op0C->getOperand(0);
-    Type *SrcTy = Op0COp->getType();
-    // fold (and (cast A), (cast B)) -> (cast (and A, B))
-    if (CastInst *Op1C = dyn_cast<CastInst>(Op1)) {
-      if (Op0C->getOpcode() == Op1C->getOpcode() && // same cast kind ?
-          SrcTy == Op1C->getOperand(0)->getType() &&
-          SrcTy->isIntOrIntVectorTy()) {
-        Value *Op1COp = Op1C->getOperand(0);
+  CastInst *Op0C = dyn_cast<CastInst>(Op0);
+  CastInst *Op1C = dyn_cast<CastInst>(Op1);
+  if (!Op0C || !Op1C)
+    return nullptr;
 
-        // Only do this if the casts both really cause code to be generated.
-        if (ShouldOptimizeCast(Op0C->getOpcode(), Op0COp, I.getType()) &&
-            ShouldOptimizeCast(Op1C->getOpcode(), Op1COp, I.getType())) {
-          Value *NewOp = Builder->CreateAnd(Op0COp, Op1COp, I.getName());
-          return CastInst::Create(Op0C->getOpcode(), NewOp, I.getType());
-        }
+  Value *Op0COp = Op0C->getOperand(0);
+  Type *SrcTy = Op0COp->getType();
+  // fold (and (cast A), (cast B)) -> (cast (and A, B))
+  if (Op0C->getOpcode() == Op1C->getOpcode() && // same cast kind ?
+      SrcTy == Op1C->getOperand(0)->getType() &&
+      SrcTy->isIntOrIntVectorTy()) {
+    Value *Op1COp = Op1C->getOperand(0);
 
-        // If this is and(cast(icmp), cast(icmp)), try to fold this even if the
-        // cast is otherwise not optimizable.  This happens for vector sexts.
-        if (ICmpInst *RHS = dyn_cast<ICmpInst>(Op1COp))
-          if (ICmpInst *LHS = dyn_cast<ICmpInst>(Op0COp))
-            if (Value *Res = FoldAndOfICmps(LHS, RHS))
-              return CastInst::Create(Op0C->getOpcode(), Res, I.getType());
-
-        // If this is and(cast(fcmp), cast(fcmp)), try to fold this even if the
-        // cast is otherwise not optimizable.  This happens for vector sexts.
-        if (FCmpInst *RHS = dyn_cast<FCmpInst>(Op1COp))
-          if (FCmpInst *LHS = dyn_cast<FCmpInst>(Op0COp))
-            if (Value *Res = FoldAndOfFCmps(LHS, RHS))
-              return CastInst::Create(Op0C->getOpcode(), Res, I.getType());
-      }
+    // Only do this if the casts both really cause code to be generated.
+    if (ShouldOptimizeCast(Op0C->getOpcode(), Op0COp, I.getType()) &&
+        ShouldOptimizeCast(Op1C->getOpcode(), Op1COp, I.getType())) {
+      Value *NewOp = Builder->CreateAnd(Op0COp, Op1COp, I.getName());
+      return CastInst::Create(Op0C->getOpcode(), NewOp, I.getType());
     }
+
+    // If this is and(cast(icmp), cast(icmp)), try to fold this even if the
+    // cast is otherwise not optimizable.  This happens for vector sexts.
+    if (ICmpInst *RHS = dyn_cast<ICmpInst>(Op1COp))
+      if (ICmpInst *LHS = dyn_cast<ICmpInst>(Op0COp))
+        if (Value *Res = FoldAndOfICmps(LHS, RHS))
+          return CastInst::Create(Op0C->getOpcode(), Res, I.getType());
+
+    // If this is and(cast(fcmp), cast(fcmp)), try to fold this even if the
+    // cast is otherwise not optimizable.  This happens for vector sexts.
+    if (FCmpInst *RHS = dyn_cast<FCmpInst>(Op1COp))
+      if (FCmpInst *LHS = dyn_cast<FCmpInst>(Op0COp))
+        if (Value *Res = FoldAndOfFCmps(LHS, RHS))
+          return CastInst::Create(Op0C->getOpcode(), Res, I.getType());
   }
   return nullptr;
 }




More information about the llvm-commits mailing list