[PATCH] D17499: [ELF] - replaced std::function with raw pointers in LinkerScript.cpp

[Rafael Espíndola via llvm-commits]

On 22 February 2016 at 13:13, David Blaikie <dblaikie at gmail.com> wrote:
> dblaikie added inline comments.
>
> ================
> Comment at: ELF/LinkerScript.cpp:120
> @@ -129,2 +119,3 @@
>    std::vector<StringRef> Tokens;
> -  llvm::StringMap<std::function<void(ScriptParser &)>> Cmd;
> +  llvm::StringMap<CmdHandler> Cmd{
> +      {"ENTRY", &ScriptParser::readEntry},
> ----------------
> Should this be static/const, then? (doesn't seem it ever gets modified, etc)

good point, yes.

Cheers,
Rafael