[PATCH] D17454: Insert two S_NOP instructions for every high level source statement.

[Konstantin Zhuravlyov via llvm-commits]

kzhuravl marked 12 inline comments as done.

================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:272
@@ +271,3 @@
+void AMDGPUPassConfig::addPreRegAlloc() {
+  if (InsertNops) {
+    addPass(createAMDGPUInsertDebugNopsPass());
----------------
tstellarAMD wrote:
> kzhuravl wrote:
> > tstellarAMD wrote:
> > > We should also be running this pass if the user specifies -g.
> > tools team specifically asked not to do this. for example, for profiling they want to run it with -g, but without inserting nops
> Ok, so the nops are required for both debugging and profiling?  Is the command line flag you added accessible from clang?
nops are only required for debugging. for profiling they want to have debug info, but no nops. command line flag is accessible from clang


http://reviews.llvm.org/D17454