[PATCH] D17460: Add prefix based function layout when profile is available.

[Easwaran Raman via llvm-commits]

eraman added inline comments.

================
Comment at: lib/ProfileData/ProfileSummary.cpp:83
@@ +82,3 @@
+  // FIXME: update when summary data is stored in module's metadata.
+  return false;
+}
----------------
return M->getMaximumFunctionCount().hasValue();

I know this doesn't work for sample profile, but it works for instrumentation profile and is better than returning false. 

================
Comment at: lib/ProfileData/ProfileSummary.cpp:100
@@ +99,3 @@
+  if (!F->getEntryCount()) {
+    return true;
+  }
----------------
I think sample profile loader pass should set 0 to the entry count. The meaning of getEntryCount() should not be dependent on the profile format that is used. (To be clear, I am not saying that should be fixed as part of this patch)


http://reviews.llvm.org/D17460