[PATCH] D5226: [Polly] Support memory intrinsics

[Hongbin Zheng via llvm-commits]

etherzhhb added a comment.

LGTM and I think this patch will be very useful.


================
Comment at: include/polly/Support/ScopHelper.h:56
@@ +55,3 @@
+/// creatable using the default constructor); never an Instruction that is not a
+/// load or store. When representing a nullptr, only the following methods are
+/// defined:
----------------
load, store or memintrinsic ...

================
Comment at: include/polly/Support/ScopHelper.h:58
@@ -56,2 +57,3 @@
+/// defined:
 /// isNull(), isInstruction(), isLoad(), isStore(), operator bool(), operator!()
 ///
----------------
isLoad(), isStore(), isMemIntrinsic() ...

================
Comment at: lib/CodeGen/BlockGenerators.cpp:321-323
@@ -320,4 +320,5 @@
 
-  for (Instruction &Inst : *BB)
+  for (Instruction &Inst : *BB) {
     copyInstruction(Stmt, &Inst, BBMap, LTS, NewAccesses);
+  }
 }
----------------
Unrelated change?


http://reviews.llvm.org/D5226