[PATCH] D15976: Supporting all entities declared in lexical scope in LLVM debug info

[Amjad Aboud via llvm-commits]

aaboud updated this revision to Diff 48614.
aaboud added a comment.

There was a minor issue with the implementation, which I fixed in this patch and improved the LIT tests to catch it as well.
Because the local entry information was saved in the DwarfFile, it could be accessed by all CompileUnits, and the way it was handled caused two different CompileUnits to handle same local entry twice leading into hitting assertion during compilation.
The fix was to move the data to the DwarfCompileUnit class, i.e. in this final patch there is no modification to the DwarfFile.h/cpp files.

Also, ran Clang-format and fixed few lines accordingly.

David, please give it a fast look, nothing changed except moving the structures from one file to another.


http://reviews.llvm.org/D15976

Files:
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.h
  test/DebugInfo/Generic/2010-04-06-NestedFnDbgInfo.ll
  test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
  test/DebugInfo/Generic/cross-cu-linkonce-distinct.ll
  test/DebugInfo/Generic/namespace.ll
  test/DebugInfo/Generic/nodebug.ll
  test/DebugInfo/Mips/InlinedFnLocalVar.ll
  test/DebugInfo/X86/InlinedFnLocalVar.ll
  test/DebugInfo/X86/PR24008.ll
  test/DebugInfo/X86/dbg-file-name.ll
  test/DebugInfo/X86/debug-dead-local-var.ll
  test/DebugInfo/X86/gnu-public-names.ll
  test/DebugInfo/X86/lexical-block-inline.ll
  test/DebugInfo/X86/lexical-block.ll
  test/DebugInfo/X86/subprogram-inline.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15976.48614.patch
Type: text/x-patch
Size: 59225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160221/c6d59fb3/attachment.bin>